Add special-order product flow for sales opportunities

src/api/sales/[id]/fetch.ts

@@ -24,7 +24,6 @@ export default createRoute(
   "get",
   ["/opportunities/:identifier"],
   async (c) => {
-    const t0 = performance.now();
     const identifier = c.req.param("identifier");
     const includeParam = c.req.query("include") ?? "";
     const includes = new Set(
@@ -80,24 +79,14 @@ export default createRoute(
     // Check Redis first — if the background refresh has kept the keys warm,
     // skip the CW calls entirely. Only fetch-and-cache on a miss.
     const cwOppId = dbRecord.cwOpportunityId;
-    const _pw0 = performance.now();
-    const _wrapPw = (label: string, p: Promise<any>) =>
-      p
-        .then((r) => {
-          console.log(
-            `[PERF:prewarm] ${label}: ${(performance.now() - _pw0).toFixed(0)}ms`,
-          );
-          return r;
-        })
-        .catch(() => {});
+    const _ignoreErrors = (p: Promise<any>) => p.catch(() => {});
 
     const prewarmPromises: Promise<any>[] = [];
     if (dbRecord.companyCwId && dbRecord.siteCwId) {
       const compId = dbRecord.companyCwId,
         siteId = dbRecord.siteCwId;
       prewarmPromises.push(
-        _wrapPw(
-          "site",
+        _ignoreErrors(
           getCachedSite(compId, siteId).then(
             (c) => c ?? fetchAndCacheSite(compId, siteId),
           ),
@@ -106,8 +95,7 @@ export default createRoute(
     }
     if (includes.has("notes") && subTtl)
       prewarmPromises.push(
-        _wrapPw(
-          "notes",
+        _ignoreErrors(
           getCachedNotes(cwOppId).then(
             (c) => c ?? fetchAndCacheNotes(cwOppId, subTtl),
           ),
@@ -115,8 +103,7 @@ export default createRoute(
       );
     if (includes.has("contacts") && subTtl)
       prewarmPromises.push(
-        _wrapPw(
-          "contacts",
+        _ignoreErrors(
           getCachedContacts(cwOppId).then(
             (c) => c ?? fetchAndCacheContacts(cwOppId, subTtl),
           ),
@@ -124,8 +111,7 @@ export default createRoute(
       );
     if (includes.has("products") && prodTtl)
       prewarmPromises.push(
-        _wrapPw(
-          "products",
+        _ignoreErrors(
           getCachedProducts(cwOppId).then(
             (c) => c ?? fetchAndCacheProducts(cwOppId, prodTtl),
           ),
@@ -138,46 +124,25 @@ export default createRoute(
       opportunities.fetchItem(identifier),
       ...prewarmPromises,
     ]);
-    const t1 = performance.now();
-    console.log(`[PERF] fetchItem + prewarm: ${(t1 - t0).toFixed(0)}ms`);
 
     // Sub-resources now hit warm Redis cache (near-instant)
-    const _st = performance.now();
-    const _wrapTimed = (label: string, p: Promise<any>) =>
-      p.then((r) => {
-        console.log(
-          `[PERF:sub] ${label}: ${(performance.now() - _st).toFixed(0)}ms`,
-        );
-        return r;
-      });
-
     const subResourcePromises: Record<string, Promise<any>> = {
-      _site: _wrapTimed("site", item.fetchSite()),
+      _site: item.fetchSite(),
     };
     if (includes.has("notes")) {
-      subResourcePromises.notes = _wrapTimed("notes", item.fetchNotes());
+      subResourcePromises.notes = item.fetchNotes();
     }
     if (includes.has("contacts")) {
-      subResourcePromises.contacts = _wrapTimed(
-        "contacts",
-        item.fetchContacts(),
-      );
+      subResourcePromises.contacts = item.fetchContacts();
     }
     if (includes.has("products")) {
-      subResourcePromises.products = _wrapTimed(
-        "products",
-        item
-          .fetchProducts()
-          .then((products) => products.map((p) => p.toJson())),
-      );
+      subResourcePromises.products = item
+        .fetchProducts()
+        .then((products) => products.map((p) => p.toJson()));
     }
 
     const keys = Object.keys(subResourcePromises);
     const results = await Promise.all(keys.map((k) => subResourcePromises[k]));
-    const t2 = performance.now();
-    console.log(
-      `[PERF] sub-resources (${keys.join(",")}): ${(t2 - t1).toFixed(0)}ms`,
-    );
 
     // Apply toJson after site is hydrated (side-effect from fetchSite)
     const gatedData = await processObjectValuePerms(
@@ -185,8 +150,8 @@ export default createRoute(
       "obj.opportunity",
       c.get("user"),
     );
-    const t3 = performance.now();
-    console.log(`[PERF] processObjectValuePerms: ${(t3 - t2).toFixed(0)}ms`);
+
+    const originalOpportunityNoteText = (gatedData as any).notes;
 
     // Attach sub-resources (skip the internal _site key)
     keys.forEach((k, i) => {
@@ -195,14 +160,17 @@ export default createRoute(
       }
     });
 
+    if (includes.has("notes")) {
+      (gatedData as any).opportunityNoteText =
+        typeof originalOpportunityNoteText === "string"
+          ? originalOpportunityNoteText
+          : null;
+    }
+
     const response = apiResponse.successful(
       "Opportunity fetched successfully!",
       gatedData,
     );
-
-    console.log(
-      `[PERF] total handler: ${(performance.now() - t0).toFixed(0)}ms (includes=${includeParam || "none"})`,
-    );
     return c.json(response, response.status as ContentfulStatusCode);
   },
   authMiddleware({ permissions: ["sales.opportunity.fetch"] }),